fix(ui): Allow Trailing Slashes #19093 #19389
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Kim <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
KSH-code
changed the title
|
/bns:deploy |
KSH-code
changed the title
| '/user-info': {component: userInfo.component}, | ||
| '/help': {component: help.component}, | ||
| '/pkce/verify': {component: PKCEVerification, noLayout: true} | ||
| // for removing trailing slash, use regex (/*)? end of the path. |
There was a problem hiding this comment.
These regexes look too permissive. I've tried in Python and '/login(/*)?' would match anything starting with /login and things like /login// would be a part of the match. Not sure that's intended. Also, why isn't there an update to the logic checking the path? The existing code looks like it doesn't expect the regex but rather a regular string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are on the
http://localhost:4000/applications/and visiting an application page by searching applications, the empty page is shown.and other redirection including end of trailing slash are too.
to solve above problem, trailing slashes should be allowed.
My first solution was to fix in argoproj/argo-ui#565. but argo-ui has been being in deprecation as far as I know. thus I will fix it by here.
Checklist:
fixes #19093